Add focus trapping to resource preview side panel #5505
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AllanOXDi and @AlexVelezLl, noticed that this PR is with status 'Needs QA' but we can only test it either at |
|
Hi @pcenov! This should be testable once merged to the hotfixes. We'll let you know once its ready for QA review. Thanks |
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
reviewed
Oct 28, 2025
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
reviewed
Oct 28, 2025
contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue
Outdated
Show resolved
Hide resolved
akolson
requested changes
Oct 28, 2025
|
@rtibbles any idea why this build is failing? |
|
Hey @AllanOXDi! could you please rebase this pr? Thanks |
AllanOXDi
force-pushed
the
focus-on-me
branch
from
ceca3e8 to
546cd43
Compare
|
Done! |
akolson
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
LGTM! Merging into hotfixes next patch release. Thanks @AllanOXDi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes focus trapping to resource preview side panel
Before
focus-resource-preview-sidebar.mp4
After
Screen.Recording.2025-10-23.at.21.54.00.mov
References
#5406
Reviewer guidance